Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: content/browser/service_worker/service_worker_cache.cc

Issue 732633002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mmenke@ comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache.cc
diff --git a/content/browser/service_worker/service_worker_cache.cc b/content/browser/service_worker/service_worker_cache.cc
index 0a1f3cd297f6822ba8d2698e063030dd8e4f7b71..1f6ab68ec91e7fc1bb146ee241d4dd8190e0e252 100644
--- a/content/browser/service_worker/service_worker_cache.cc
+++ b/content/browser/service_worker/service_worker_cache.cc
@@ -9,6 +9,7 @@
#include "base/files/file_path.h"
#include "base/guid.h"
#include "base/message_loop/message_loop_proxy.h"
+#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_util.h"
#include "content/browser/service_worker/service_worker_cache.pb.h"
#include "content/public/browser/browser_thread.h"
@@ -446,6 +447,11 @@ class ServiceWorkerCache::BlobReader : public net::URLRequest::Delegate {
}
void OnResponseStarted(net::URLRequest* request) override {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/423948 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "423948 ServiceWorkerCache::BlobReader::OnResponseStarted"));
+
if (!request->status().is_success()) {
callback_.Run(entry_.Pass(), false);
return;
@@ -462,6 +468,11 @@ class ServiceWorkerCache::BlobReader : public net::URLRequest::Delegate {
}
void OnReadCompleted(net::URLRequest* request, int bytes_read) override {
+ // TODO(vadimt): Remove ScopedTracker below once crbug.com/423948 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION(
+ "423948 ServiceWorkerCache::BlobReader::OnReadCompleted"));
+
if (!request->status().is_success()) {
callback_.Run(entry_.Pass(), false);
return;
« no previous file with comments | « content/browser/loader/resource_loader.cc ('k') | content/browser/service_worker/service_worker_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698