Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: Source/devtools/front_end/ui/StatusBarButton.js

Issue 732603002: DevTools: align more status bar button usages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/toolbox/responsiveDesignView.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/StatusBarButton.js
diff --git a/Source/devtools/front_end/ui/StatusBarButton.js b/Source/devtools/front_end/ui/StatusBarButton.js
index 1ea4c7397fbdbd4c2271bb1dac04aa391420877e..2a73a224f4be46f3455376b972fc252cbb6a4ab2 100644
--- a/Source/devtools/front_end/ui/StatusBarButton.js
+++ b/Source/devtools/front_end/ui/StatusBarButton.js
@@ -370,14 +370,12 @@ WebInspector.StatusBarButtonBase.prototype = {
this.makeLongClickEnabled();
this.longClickGlyph = this.element.createChild("div", "fill long-click-glyph");
- this.longClickGlyphShadow = this.element.createChild("div", "fill long-click-glyph shadow");
var longClickDownListener = this._showOptions.bind(this);
this.addEventListener("longClickDown", longClickDownListener, this);
this._longClickOptionsData = {
glyphElement: this.longClickGlyph,
- glyphShadowElement: this.longClickGlyphShadow,
longClickDownListener: longClickDownListener
};
}
@@ -386,7 +384,6 @@ WebInspector.StatusBarButtonBase.prototype = {
if (!this._longClickOptionsData)
return;
this.element.removeChild(this._longClickOptionsData.glyphElement);
- this.element.removeChild(this._longClickOptionsData.glyphShadowElement);
this.removeEventListener("longClickDown", this._longClickOptionsData.longClickDownListener, this);
delete this._longClickOptionsData;
@@ -497,13 +494,13 @@ WebInspector.StatusBarButton.prototype = {
/**
* @constructor
- * @param {!Element} parentElement
+ * @param {!Element=} parentElement
*/
WebInspector.StatusBar = function(parentElement)
{
/** @type {!Array.<!WebInspector.StatusBarItem>} */
this._items = [];
- this.element = parentElement.createChild("div", "status-bar");
+ this.element = parentElement ? parentElement.createChild("div", "status-bar") : createElementWithClass("div", "status-bar");
}
WebInspector.StatusBar.prototype = {
« no previous file with comments | « Source/devtools/front_end/toolbox/responsiveDesignView.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698