Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: Source/devtools/front_end/components/InspectorView.js

Issue 732603002: DevTools: align more status bar button usages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/InspectorView.js
diff --git a/Source/devtools/front_end/components/InspectorView.js b/Source/devtools/front_end/components/InspectorView.js
index 869ef179f3588f98636c38c04b16b4e1cabf0712..8d7edab834cb25e4f122f7a9d4a737b81963ccca 100644
--- a/Source/devtools/front_end/components/InspectorView.js
+++ b/Source/devtools/front_end/components/InspectorView.js
@@ -56,15 +56,14 @@ WebInspector.InspectorView = function()
var headerElement = this._tabbedPane.headerElement();
headerElement.parentElement.insertBefore(this._toolbarElement, headerElement);
- this._leftToolbarElement = this._toolbarElement.createChild("div", "toolbar-controls-left");
+ this._leftToolbar = new WebInspector.StatusBar(this._toolbarElement);
this._toolbarElement.appendChild(headerElement);
- this._rightToolbarElement = this._toolbarElement.createChild("div", "toolbar-controls-right");
- this._toolbarItems = [];
+ this._rightToolbar = new WebInspector.StatusBar(this._toolbarElement);
this._closeButtonToolbarItem = createElementWithClass("div", "toolbar-close-button-item");
var closeButtonElement = this._closeButtonToolbarItem.createChild("div", "close-button");
closeButtonElement.addEventListener("click", InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost), true);
- this._rightToolbarElement.appendChild(this._closeButtonToolbarItem);
+ this._toolbarElement.appendChild(this._closeButtonToolbarItem);
this._panels = {};
// Used by tests.
@@ -131,8 +130,7 @@ WebInspector.InspectorView.prototype = {
*/
appendToLeftToolbar: function(item)
{
- this._toolbarItems.push(item);
- this._leftToolbarElement.appendChild(item.element);
+ this._leftToolbar.appendStatusBarItem(item);
},
/**
@@ -140,8 +138,7 @@ WebInspector.InspectorView.prototype = {
*/
appendToRightToolbar: function(item)
{
- this._toolbarItems.push(item);
- this._rightToolbarElement.insertBefore(item.element, this._closeButtonToolbarItem);
+ this._rightToolbar.appendStatusBarItem(item);
},
/**
@@ -205,8 +202,8 @@ WebInspector.InspectorView.prototype = {
{
this._currentPanelLocked = WebInspector.targetManager.allTargetsSuspended();
this._tabbedPane.setCurrentTabLocked(this._currentPanelLocked);
- for (var i = 0; i < this._toolbarItems.length; ++i)
- this._toolbarItems[i].setEnabled(!this._currentPanelLocked);
+ this._leftToolbar.setEnabled(!this._currentPanelLocked);
+ this._rightToolbar.setEnabled(!this._currentPanelLocked);
},
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698