Source/bindings/core/v8/ScriptController.cpp - Issue 732593002: DevTools: Make StepInto work across script boundaries and Blink process tasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptController.cpp

Issue 732593002: DevTools: Make StepInto work across script boundaries and Blink process tasks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: added new test debugger-step-into-document-write.html Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/sources/debugger/debugger-step-into-across-timeouts.html ('K') | « LayoutTests/inspector/sources/debugger/resources/framework.js ('k') | Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp » ('j') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptController.cpp

diff --git a/Source/bindings/core/v8/ScriptController.cpp b/Source/bindings/core/v8/ScriptController.cpp

index 98eb5c2a9e0d02780786aa2c0a1ccef320b7998f..1cf3dcb30df28b701eb2df271afc79e60fa7778e 100644

--- a/Source/bindings/core/v8/ScriptController.cpp

+++ b/Source/bindings/core/v8/ScriptController.cpp

@@ -160,7 +160,7 @@ v8::Local<v8::Value> ScriptController::callFunction(ExecutionContext* context, v

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline.stack"), "CallStack", "stack", InspectorCallStackEvent::currentCallStack());

// FIXME(361045): remove InspectorInstrumentation calls once DevTools Timeline migrates to tracing.

InspectorInstrumentationCookie cookie;

- if (InspectorInstrumentation::timelineAgentEnabled(context)) {

+ if (InspectorInstrumentation::hasFrontends()) {

int scriptId = 0;

String resourceName;

int lineNumber = 1;