LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html - Issue 732593002: DevTools: Make StepInto work across script boundaries and Blink process tasks.

Unified Diff: LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html

Issue 732593002: DevTools: Make StepInto work across script boundaries and Blink process tasks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: added new test debugger-step-into-document-write.html Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/inspector/sources/debugger/debugger-step-into-across-timeouts.html ('K') | « LayoutTests/inspector/sources/debugger/debugger-step-into-inlined-scripts-expected.txt ('k') | LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout-expected.txt » ('j') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html

diff --git a/LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html b/LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html

similarity index 56%

copy from LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html

copy to LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html

index b3c1175158efb1c8a88261175e353a1c2474e69f..5bc7d344139698a676c6c9db8aa599deb04d1239 100644

--- a/LayoutTests/inspector/sources/debugger/frameworks-step-from-framework.html

+++ b/LayoutTests/inspector/sources/debugger/frameworks-step-into-skips-setTimeout.html

@@ -5,12 +5,24 @@

+var counter = 0;

function testFunction()

{

- Framework.safeRun(Framework.breakInFramework, Framework.empty)

- Framework.safeRun(Framework.empty); // should not step inside

- Framework.empty(); // dummy call

- Framework.sendXHR('/foo?a=b');

+ Framework.scheduleUntilDone(callback, 0);

+function callback()

+ ++counter;

+ if (counter === 1)

+ stop();

+ return counter === 2;

+function stop()

+ debugger;

}

function test()

@@ -18,15 +30,10 @@ function test()

var frameworkRegexString = "/framework\\.js$";

WebInspector.settings.skipStackFramesPattern.set(frameworkRegexString);

- InspectorTest.setQuiet(true);

- InspectorTest.startDebuggerTest(step1);

- var xhrPane;

+ InspectorTest.startDebuggerTest(step1, true);

function step1()

{

- xhrPane = WebInspector.panels.sources.sidebarPanes.xhrBreakpoints;

- xhrPane._setBreakpoint("foo", true);

InspectorTest.runTestFunctionAndWaitUntilPaused(step2);

}

@@ -34,19 +41,15 @@ function test()

{

var actions = [

"Print", // debugger;

- "StepInto", "Print",

- "StepOver", "Print",

"StepOut", "Print",

- "StepInto", "Print", // should not step inside

- "Resume", "Print", // should stop on XHR.send()

- "StepInto", "Print", // should step inside framework

+ "StepInto", "Print",

+ "StepInto", "Print", // Should NOT stop on setTimeout() inside framework

];

InspectorTest.waitUntilPausedAndPerformSteppingActions(actions, step3);

}

function step3()

{

- xhrPane._removeBreakpoint("foo");

InspectorTest.completeDebuggerTest();

}

@@ -57,7 +60,7 @@ function test()

<p>

-Tests stepping from framework call frames.

+Tests that stepping into blackboxed framework will not pause on setTimeout() inside the framework.

</p>

</body>

</html>