Issue 732583002: Subzero: Auto-set -build-on-read=0 for .ll input files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732583002: Subzero: Auto-set -build-on-read=0 for .ll input files. (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth

Modified:
6 years, 1 month ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Auto-set -build-on-read=0 for .ll input files. This is purely for convenience of personal testing/debugging. To demonstrate its correctness in this CL, -build-on-read=0 is removed from the two .ll lit tests that explicitly use it, and also from the crosstest.py script. The lit test wrapper run-llvm2ice.py is left unchanged to be safe. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=51596d43bbc8d0fb11a5f68a734f632a2cdbf3e9

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	pydir/crosstest.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/llvm2ice.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests_lit/reader_tests/insertextract-err.ll	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests_lit/reader_tests/nacl-fake-intrinsic.ll	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

6 years, 1 month ago (2014-11-14 17:52:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
51596d43bbc8d0fb11a5f68a734f632a2cdbf3e9 (presubmit successful).