Implement 'setVariableValue' for debugger block scopes.

Implement 'setVariableValue' for debugger block scopes.

R=aandrey@chromium.org, rossberg@chromium.org, yurys@chromium.org
BUG=v8:3690
LOG=N

Committed: https://chromium.googlesource.com/v8/v8/+/7e69b2f996b5f1b77a14474f9b8dd9731fd04f9f

[Dmitry Lomov (no reviews), 2014-11-14 12:13:11]

dslomov@chromium.org changed reviewers:
+ aandrey@chromium.org, yurys@chromium.org

[Dmitry Lomov (no reviews), 2014-11-14 12:13:11]

dslomov@chromium.org changed required reviewers:
+ rossberg@chromium.org

[Dmitry Lomov (no reviews), 2014-11-14 12:13:36]

rossberg: PTAL
aandrey, yurys: FYI

[yurys, 2014-11-14 12:27:47]

lgtm

[rossberg, 2014-11-14 12:35:25]

LGTM, I'd just suggest one more test.

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
test/mjsunit/harmony/debug-evaluate-blockscopes.js:74: let i = 1;
Considering stack allocated block variables being up next, maybe already have 2
versions of this test: one where i will (hopefully) be stack-allocated soon, and
one where it will still be context-allocated.

[aandrey, 2014-11-14 12:39:58]

lgtm

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
test/mjsunit/harmony/debug-evaluate-blockscopes.js:88:
allScopes[0].setVariableValue('i', 2);
nit: ' or " (see 3 lines above)

[Dmitry Lomov (no reviews), 2014-11-14 13:38:27]

Comments addressed, landing

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
test/mjsunit/harmony/debug-evaluate-blockscopes.js:74: let i = 1;
On 2014/11/14 12:35:24, rossberg wrote:
> Considering stack allocated block variables being up next, maybe already have
2
> versions of this test: one where i will (hopefully) be stack-allocated soon,
and
> one where it will still be context-allocated.

Done.

https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-e...
test/mjsunit/harmony/debug-evaluate-blockscopes.js:88:
allScopes[0].setVariableValue('i', 2);
On 2014/11/14 12:39:58, aandrey wrote:
> nit: ' or " (see 3 lines above)

Done.

[Dmitry Lomov (no reviews), 2014-11-14 13:39:26]

Committed patchset #2 (id:20001) manually as
7e69b2f996b5f1b77a14474f9b8dd9731fd04f9f (presubmit successful).