Issue 732463003: [turbofan] Push JSToNumber conversions into Phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732463003: [turbofan] Push JSToNumber conversions into Phis. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

[turbofan] Push JSToNumber conversions into Phis. This essentially performs the following transformation JSToNumber(phi(x1,...,xn,control):primitive) => phi(JSToNumber(x1),...,JSToNumber(xn),control):number which is similar to what we already do for JSToBoolean. TEST=mjsunit/asm R=svenpanne@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/1d4dfd9ac4b76623cad547cb4f76caca8d553395

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -10 lines)			Patch
M	src/compiler/js-typed-lowering.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View		5 chunks	+55 lines, -10 lines	0 comments	Download
M	test/cctest/cctest.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	test/mjsunit/asm/if-tonumber.js	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-18 11:34:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1d4dfd9ac4b76623cad547cb4f76caca8d553395 (presubmit successful).