Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 732433002: Add some modifiers to eventSender for test. (Closed)

Created:
6 years, 1 month ago by zino
Modified:
6 years, 1 month ago
Reviewers:
tkent, Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add some modifiers to eventSender for test. Some layout test (especially such as mouse event) will use the modifiers. BUG=none Committed: https://crrev.com/ffc700e337d3c0d4c1348b1da53ee16aa0c3ed21 Cr-Commit-Position: refs/heads/master@{#304383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/shell/renderer/test_runner/event_sender.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zino
Please take a look. Especially, this is needed in https://codereview.chromium.org/727593003/.
6 years, 1 month ago (2014-11-14 07:38:01 UTC) #2
Rick Byers
This LGTM - just need an OWNER here.
6 years, 1 month ago (2014-11-14 19:46:30 UTC) #4
tkent
lgtm
6 years, 1 month ago (2014-11-17 03:25:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732433002/1
6 years, 1 month ago (2014-11-17 03:25:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 04:05:37 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 04:06:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffc700e337d3c0d4c1348b1da53ee16aa0c3ed21
Cr-Commit-Position: refs/heads/master@{#304383}

Powered by Google App Engine
This is Rietveld 408576698