Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: net/url_request/url_request_job_manager.cc

Issue 732423002: Update from chromium https://crrev.com/304586 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_job_manager.h ('k') | net/url_request/url_request_simple_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job_manager.cc
diff --git a/net/url_request/url_request_job_manager.cc b/net/url_request/url_request_job_manager.cc
index 6fcff221616ffad4efffad9a457197c6d4d070c3..a1540fadc5ac7ac9aa9d052a75e5a3f30e13532a 100644
--- a/net/url_request/url_request_job_manager.cc
+++ b/net/url_request/url_request_job_manager.cc
@@ -68,18 +68,6 @@ URLRequestJob* URLRequestJobManager::CreateJob(
// See if the request should be intercepted.
//
-
- // TODO(pauljensen): Remove this when AppCacheInterceptor is a
- // ProtocolHandler, see crbug.com/161547.
- if (!(request->load_flags() & LOAD_DISABLE_INTERCEPT)) {
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- URLRequestJob* job = (*i)->MaybeIntercept(request, network_delegate);
- if (job)
- return job;
- }
- }
-
URLRequestJob* job = job_factory->MaybeCreateJobWithProtocolHandler(
scheme, request, network_delegate);
if (job)
@@ -108,7 +96,6 @@ URLRequestJob* URLRequestJobManager::MaybeInterceptRedirect(
const GURL& location) const {
DCHECK(IsAllowedThread());
if (!request->url().is_valid() ||
- request->load_flags() & LOAD_DISABLE_INTERCEPT ||
request->status().status() == URLRequestStatus::CANCELED) {
return NULL;
}
@@ -120,15 +107,6 @@ URLRequestJob* URLRequestJobManager::MaybeInterceptRedirect(
if (!job_factory->IsHandledProtocol(scheme))
return NULL;
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- URLRequestJob* job = (*i)->MaybeInterceptRedirect(request,
- network_delegate,
- location);
- if (job)
- return job;
- }
-
URLRequestJob* job =
request->context()->job_factory()->MaybeInterceptRedirect(
request, network_delegate, location);
@@ -142,7 +120,6 @@ URLRequestJob* URLRequestJobManager::MaybeInterceptResponse(
URLRequest* request, NetworkDelegate* network_delegate) const {
DCHECK(IsAllowedThread());
if (!request->url().is_valid() ||
- request->load_flags() & LOAD_DISABLE_INTERCEPT ||
request->status().status() == URLRequestStatus::CANCELED) {
return NULL;
}
@@ -154,14 +131,6 @@ URLRequestJob* URLRequestJobManager::MaybeInterceptResponse(
if (!job_factory->IsHandledProtocol(scheme))
return NULL;
- InterceptorList::const_iterator i;
- for (i = interceptors_.begin(); i != interceptors_.end(); ++i) {
- URLRequestJob* job = (*i)->MaybeInterceptResponse(request,
- network_delegate);
- if (job)
- return job;
- }
-
URLRequestJob* job =
request->context()->job_factory()->MaybeInterceptResponse(
request, network_delegate);
@@ -181,29 +150,6 @@ bool URLRequestJobManager::SupportsScheme(const std::string& scheme) {
return false;
}
-void URLRequestJobManager::RegisterRequestInterceptor(
- URLRequest::Interceptor* interceptor) {
- DCHECK(IsAllowedThread());
-
- base::AutoLock locked(lock_);
-
- DCHECK(std::find(interceptors_.begin(), interceptors_.end(), interceptor) ==
- interceptors_.end());
- interceptors_.push_back(interceptor);
-}
-
-void URLRequestJobManager::UnregisterRequestInterceptor(
- URLRequest::Interceptor* interceptor) {
- DCHECK(IsAllowedThread());
-
- base::AutoLock locked(lock_);
-
- InterceptorList::iterator i =
- std::find(interceptors_.begin(), interceptors_.end(), interceptor);
- DCHECK(i != interceptors_.end());
- interceptors_.erase(i);
-}
-
URLRequestJobManager::URLRequestJobManager()
: allowed_thread_(0),
allowed_thread_initialized_(false) {
« no previous file with comments | « net/url_request/url_request_job_manager.h ('k') | net/url_request/url_request_simple_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698