Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 732413004: Add support for Page.getResourceTree (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
esprhen, esprehn, abarth-chromium
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add support for Page.getResourceTree Unfortunately we don't yet have a way to walk into imports, so this only is the first-level of the source tree, but this is a huge step forward. You can now click to set breakpoints, however setting breakpoints crashes sky. I had to fix Console.log to flush stdout so that I could actually debug my timing-out test. Also had to fix Chai to dump differences for deepEqual. R=esprehn@chromium.org, abarth@chromium.org, esprhen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0820a82bc3796271adaa3b06ea88c3a13c3e1593

Patch Set 1 #

Total comments: 1

Patch Set 2 : less frustration #

Total comments: 8

Patch Set 3 : Fix per review #

Patch Set 4 : Add FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -7 lines) Patch
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M sky/framework/inspector/page-agent.sky View 1 2 3 3 chunks +56 lines, -5 lines 0 comments Download
A sky/tests/inspector/page-agent-get-resource-tree.sky View 1 chunk +43 lines, -0 lines 0 comments Download
A sky/tests/inspector/page-agent-get-resource-tree-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/tests/resources/chai.sky View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
eseidel
6 years, 1 month ago (2014-11-18 23:07:18 UTC) #1
abarth-chromium
https://codereview.chromium.org/732413004/diff/1/sky/framework/inspector/page-agent.sky File sky/framework/inspector/page-agent.sky (right): https://codereview.chromium.org/732413004/diff/1/sky/framework/inspector/page-agent.sky#newcode40 sky/framework/inspector/page-agent.sky:40: // WTF? Why is !![] == true in this ...
6 years, 1 month ago (2014-11-18 23:08:43 UTC) #2
eseidel
muzzled. ptal.
6 years, 1 month ago (2014-11-18 23:11:39 UTC) #3
esprehn
This doesn't handle Shadow DOM, you need to look for a .shadowRoot on every element ...
6 years, 1 month ago (2014-11-18 23:23:59 UTC) #5
eseidel
ptal
6 years, 1 month ago (2014-11-18 23:42:53 UTC) #6
esprehn
lgtm
6 years, 1 month ago (2014-11-18 23:50:52 UTC) #7
eseidel
6 years, 1 month ago (2014-11-18 23:53:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
0820a82bc3796271adaa3b06ea88c3a13c3e1593.

Powered by Google App Engine
This is Rietveld 408576698