Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 732293002: Copy org.chromium.LibCrosService.conf to chromeos/dbus/services (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews, hashimoto+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy org.chromium.LibCrosService.conf to chromeos/dbus/services This is a part of a series of patches to move org.chromium.LibCrosServie.conf to chromeos/dbus/services Planned steps: 1. Copy org.chromium.LibCrosService.conf to chromeos/dbus/services. [This patch] 2. Change chromeos-chrome-9999.ebuild to use the conf file in chromeos/dbus/services. 3. Remove the original conf file in chrome/browser/chromeos/dbus. BUG=433744 Committed: https://crrev.com/95d0340d12a83c6159aa5d8a877405ba84b37096 Cr-Commit-Position: refs/heads/master@{#304572}

Patch Set 1 : git mv chrome/browser/chromeos/dbus/org.chromium.LibCrosService.conf chromeos/dbus/services #

Patch Set 2 : Please review this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + chromeos/dbus/services/org.chromium.LibCrosService.conf View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
6 years, 1 month ago (2014-11-18 05:49:35 UTC) #2
satorux1
lgtm
6 years, 1 month ago (2014-11-18 05:51:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732293002/20001
6 years, 1 month ago (2014-11-18 05:54:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-18 06:41:25 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 06:42:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95d0340d12a83c6159aa5d8a877405ba84b37096
Cr-Commit-Position: refs/heads/master@{#304572}

Powered by Google App Engine
This is Rietveld 408576698