Issue 732273002: Move GpuImpl into services/gles2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732273002: Move GpuImpl into services/gles2 (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move GpuImpl into services/gles2 This class logically belongs to the gles2 service implementation, not the native_viewport implementation. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c3958317253249e3cc5f9fbe702e967dfdb5c5f2

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -96 lines)			Patch
M	mojo/services/gles2/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/services/gles2/DEPS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	mojo/services/gles2/gpu_impl.h	View	0 chunks	+-1 lines, --1 lines	1 comment	Download
A +	mojo/services/gles2/gpu_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/native_viewport/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	mojo/services/native_viewport/gpu_impl.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	mojo/services/native_viewport/gpu_impl.cc	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	mojo/services/native_viewport/main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/shell/context.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/732273002/diff/1/mojo/services/gles2/gpu_impl.h File mojo/services/gles2/gpu_impl.h (right): https://codereview.chromium.org/732273002/diff/1/mojo/services/gles2/gpu_impl.h#newcode41 mojo/services/gles2/gpu_impl.h:41: // We need to share these across all ...

6 years, 1 month ago (2014-11-18 05:19:45 UTC) #2

abarth-chromium

6 years, 1 month ago (2014-11-18 06:17:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c3958317253249e3cc5f9fbe702e967dfdb5c5f2 (presubmit successful).

Expand Messages | Collapse Messages