Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 732253004: Minor spelling fixes in base/tracked_objects. (Closed)

Created:
6 years, 1 month ago by mithro-old
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Minor spelling fixes in base/tracked_objects. Committed: https://crrev.com/5eb58501e72f62a0e5d9a316fdc5aa17540ad110 Cr-Commit-Position: refs/heads/master@{#304852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M base/tracked_objects.h View 10 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
mithro-old
Hi! I was reading the documentation in base/tracked_objects and noticed these spelling mistakes. For git-blame ...
6 years, 1 month ago (2014-11-19 04:04:45 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 1 month ago (2014-11-19 06:26:15 UTC) #3
Ilya Sherman
+Lei for OWNERS approval
6 years, 1 month ago (2014-11-19 06:27:28 UTC) #7
Ilya Sherman
On 2014/11/19 04:04:45, mithro wrote: > For git-blame reasons, it might make sense for one ...
6 years, 1 month ago (2014-11-19 06:29:12 UTC) #8
mithro-old
On 2014/11/19 06:29:12, Ilya Sherman wrote: > On 2014/11/19 04:04:45, mithro wrote: > > For ...
6 years, 1 month ago (2014-11-19 07:16:17 UTC) #9
Lei Zhang
lgtm We still have "chormium" in a translation string somewhere. ;)
6 years, 1 month ago (2014-11-19 18:03:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732253004/1
6 years, 1 month ago (2014-11-19 18:05:09 UTC) #12
jar (doing other things)
LGTM thanks!!!!!
6 years, 1 month ago (2014-11-19 18:06:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 18:56:05 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 18:56:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eb58501e72f62a0e5d9a316fdc5aa17540ad110
Cr-Commit-Position: refs/heads/master@{#304852}

Powered by Google App Engine
This is Rietveld 408576698