Issue 732253002: options: Fix focus "Show advanced settings..." click focus regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732253002: options: Fix focus "Show advanced settings..." click focus regression. (Closed)

Created:
6 years, 1 month ago by Dan Beam

Modified:
6 years, 1 month ago

Reviewers:
michaelpg

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-settings-focus

Project:
chromium

Visibility:
Public.

More Reviews

Description

options: Fix focus "Show advanced settings..." click focus regression. R=michaelpg@chromium.org BUG=427387

Patch Set 1 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+5 lines, -5 lines	0 comments	Download
	M	ui/webui/resources/js/cr/ui/focus_outline_manager.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Beam

alternatively the less invasive but slightly more hacky: https://codereview.chromium.org/727303005/

6 years, 1 month ago (2014-11-18 03:35:39 UTC) #3

michaelpg

lgtm On 2014/11/18 03:35:39, Dan Beam wrote: > alternatively the less invasive but slightly more ...

6 years, 1 month ago (2014-11-18 03:50:27 UTC) #4

Dan Beam

6 years, 1 month ago (2014-11-18 06:41:53 UTC) #5

On 2014/11/18 03:50:27, michaelpg wrote:
> lgtm
> 
> On 2014/11/18 03:35:39, Dan Beam wrote:
> > alternatively the less invasive but slightly more hacky:
> > https://codereview.chromium.org/727303005/
> 
> seems like this way is the Right Way to Do It.

went with the other CL after making less hacky

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages