Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: sky/tests/dom/appendChild.sky

Issue 732203004: Clean up child checks in ContainerNode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add back secondary hierarchy checks. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/tests/dom/appendChild-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/dom/appendChild.sky
diff --git a/sky/tests/dom/appendChild.sky b/sky/tests/dom/appendChild.sky
new file mode 100644
index 0000000000000000000000000000000000000000..60da8036d7fffb7209712b2b6e57a2818308c8f7
--- /dev/null
+++ b/sky/tests/dom/appendChild.sky
@@ -0,0 +1,76 @@
+<sky>
+<import src="../resources/chai.sky" />
+<import src="../resources/mocha.sky" />
+<import src="../resources/dom-utils.sky" as="DomUtils" />
+<script>
+describe("appendChild", function() {
+ var childElementCount = DomUtils.childElementCount;
+ var childNodeCount = DomUtils.childNodeCount;
+
+ it("should throw with invalid arguments", function() {
+ var parent = document.createElement("div");
+ assert.throws(function() {
+ parent.appendChild();
+ });
+ assert.throws(function() {
+ parent.appendChild(null);
+ });
+ assert.throws(function() {
+ parent.appendChild({tagName: "div"});
+ });
+ });
+
+ it("should insert children", function() {
+ var parent = document.createElement("div");
+ var child1 = parent.appendChild(document.createElement("div"));
+ var child2 = parent.appendChild(new Text(" text "));
+ var child3 = parent.appendChild(new Text(" "));
+ var child4 = parent.appendChild(document.createElement("div"));
+ assert.equal(child1.parentNode, parent);
+ assert.equal(child2.parentNode, parent);
+ assert.equal(child3.parentNode, parent);
+ assert.equal(child4.parentNode, parent);
+ assert.equal(childNodeCount(parent), 4);
+ assert.equal(childElementCount(parent), 2);
+ });
+
+ it("should insert children with a fragment", function() {
+ var fragment = document.createDocumentFragment();
+ var child1 = fragment.appendChild(document.createElement("div"));
+ var child2 = fragment.appendChild(new Text(" text "));
+ var child3 = fragment.appendChild(new Text(" "));
+ var child4 = fragment.appendChild(document.createElement("div"));
+ var parent = document.createElement("div");
+ parent.appendChild(fragment);
+ assert.equal(child1.parentNode, parent);
+ assert.equal(child2.parentNode, parent);
+ assert.equal(child3.parentNode, parent);
+ assert.equal(child4.parentNode, parent);
+ assert.equal(childNodeCount(parent), 4);
+ assert.equal(childElementCount(parent), 2);
+ });
+
+ it("should throw when inserting a tree scope", function() {
+ var parent = document.createElement("div");
+ var doc = new Document();
+ var shadowRoot = document.createElement("span").createShadowRoot();
+ assert.throws(function() {
+ parent.appendChild(doc);
+ });
+ assert.throws(function() {
+ parent.appendChild(shadowRoot);
+ });
+ assert.throws(function() {
+ doc.appendChild(fragment);
+ });
+ });
+
+ it("should throw when appending to a text", function() {
+ var parent = new Text();
+ assert.throws(function() {
+ parent.appendChild(document.createElement("div"));
+ });
+ });
+});
+</script>
+</sky>
« no previous file with comments | « sky/engine/core/dom/Range.cpp ('k') | sky/tests/dom/appendChild-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698