sky/engine/core/dom/ContainerNode.h - Issue 732203004: Clean up child checks in ContainerNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/ContainerNode.h

Issue 732203004: Clean up child checks in ContainerNode. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: dry Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/ContainerNode.h

diff --git a/sky/engine/core/dom/ContainerNode.h b/sky/engine/core/dom/ContainerNode.h

index 5ad3ce0971f353508213782f5eacec7e92fcb477..f001f37b5c2fca0c24afb0eaad8aa1e10b23080f 100644

--- a/sky/engine/core/dom/ContainerNode.h

+++ b/sky/engine/core/dom/ContainerNode.h

@@ -142,10 +142,8 @@ private:

void notifyNodeInsertedInternal(Node&, NodeVector& postInsertionNotificationTargets);

void notifyNodeRemoved(Node&);

- inline bool checkAcceptChildGuaranteedNodeTypes(const Node& newChild, ExceptionState&) const;

- inline bool checkAcceptChild(const Node* newChild, const Node* oldChild, ExceptionState&) const;

+ inline void checkAcceptChild(const Node* newChild, const Node* oldChild, ExceptionState&) const;

inline bool containsConsideringHostElements(const Node&) const;

- inline bool isChildTypeAllowed(const Node& child) const;

void attachChildren(const AttachContext& = AttachContext());

void detachChildren(const AttachContext& = AttachContext());