Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: sky/engine/core/dom/Document.h

Issue 732203004: Clean up child checks in ContainerNode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add back secondary hierarchy checks. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/ContainerNode.cpp ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 377
378 void attachRange(Range*); 378 void attachRange(Range*);
379 void detachRange(Range*); 379 void detachRange(Range*);
380 380
381 void updateRangesAfterChildrenChanged(ContainerNode*); 381 void updateRangesAfterChildrenChanged(ContainerNode*);
382 void updateRangesAfterNodeMovedToAnotherDocument(const Node&); 382 void updateRangesAfterNodeMovedToAnotherDocument(const Node&);
383 // nodeChildrenWillBeRemoved is used when removing all node children at once . 383 // nodeChildrenWillBeRemoved is used when removing all node children at once .
384 void nodeChildrenWillBeRemoved(ContainerNode&); 384 void nodeChildrenWillBeRemoved(ContainerNode&);
385 // nodeWillBeRemoved is only safe when removing one node at a time. 385 // nodeWillBeRemoved is only safe when removing one node at a time.
386 void nodeWillBeRemoved(Node&); 386 void nodeWillBeRemoved(Node&);
387 bool canReplaceChild(const Node& newChild, const Node& oldChild) const;
388 387
389 void didInsertText(Node*, unsigned offset, unsigned length); 388 void didInsertText(Node*, unsigned offset, unsigned length);
390 void didRemoveText(Node*, unsigned offset, unsigned length); 389 void didRemoveText(Node*, unsigned offset, unsigned length);
391 void didMergeTextNodes(Text& oldNode, unsigned offset); 390 void didMergeTextNodes(Text& oldNode, unsigned offset);
392 void didSplitTextNode(Text& oldNode); 391 void didSplitTextNode(Text& oldNode);
393 392
394 void clearDOMWindow() { m_domWindow = nullptr; } 393 void clearDOMWindow() { m_domWindow = nullptr; }
395 LocalDOMWindow* domWindow() const { return m_domWindow; } 394 LocalDOMWindow* domWindow() const { return m_domWindow; }
396 395
397 static void registerEventFactory(PassOwnPtr<EventFactoryBase>); 396 static void registerEventFactory(PassOwnPtr<EventFactoryBase>);
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 void updateStyle(StyleRecalcChange); 636 void updateStyle(StyleRecalcChange);
638 637
639 void detachParser(); 638 void detachParser();
640 639
641 virtual bool isDocument() const override final { return true; } 640 virtual bool isDocument() const override final { return true; }
642 641
643 virtual void childrenChanged(const ChildrenChange&) override; 642 virtual void childrenChanged(const ChildrenChange&) override;
644 643
645 virtual String nodeName() const override final; 644 virtual String nodeName() const override final;
646 virtual NodeType nodeType() const override final; 645 virtual NodeType nodeType() const override final;
647 virtual bool childTypeAllowed(NodeType) const override final;
648 virtual PassRefPtr<Node> cloneNode(bool deep = true) override final; 646 virtual PassRefPtr<Node> cloneNode(bool deep = true) override final;
649 647
650 #if !ENABLE(OILPAN) 648 #if !ENABLE(OILPAN)
651 virtual void refExecutionContext() override final { ref(); } 649 virtual void refExecutionContext() override final { ref(); }
652 virtual void derefExecutionContext() override final { deref(); } 650 virtual void derefExecutionContext() override final { deref(); }
653 #endif 651 #endif
654 652
655 virtual const KURL& virtualURL() const override final; // Same as url(), but needed for ExecutionContext to implement it without a performance loss for dire ct calls. 653 virtual const KURL& virtualURL() const override final; // Same as url(), but needed for ExecutionContext to implement it without a performance loss for dire ct calls.
656 virtual KURL virtualCompleteURL(const String&) const override final; // Same as completeURL() for the same reason as above. 654 virtual KURL virtualCompleteURL(const String&) const override final; // Same as completeURL() for the same reason as above.
657 655
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 Node* eventTargetNodeForDocument(Document*); 838 Node* eventTargetNodeForDocument(Document*);
841 839
842 } // namespace blink 840 } // namespace blink
843 841
844 #ifndef NDEBUG 842 #ifndef NDEBUG
845 // Outside the WebCore namespace for ease of invocation from gdb. 843 // Outside the WebCore namespace for ease of invocation from gdb.
846 void showLiveDocumentInstances(); 844 void showLiveDocumentInstances();
847 #endif 845 #endif
848 846
849 #endif // Document_h 847 #endif // Document_h
OLDNEW
« no previous file with comments | « sky/engine/core/dom/ContainerNode.cpp ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698