Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(884)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: sky/tests/dom/appendChild-expected.txt
Issue
732203004
:
Clean up child checks in ContainerNode. (Closed)
Base URL: git@github.com:domokit/mojo.git@master
Patch Set: dry
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
sky/engine/core/dom/ContainerNode.h
sky/engine/core/dom/ContainerNode.cpp
sky/engine/core/dom/Document.h
sky/engine/core/dom/Document.cpp
sky/engine/core/dom/DocumentFragment.h
sky/engine/core/dom/DocumentFragment.cpp
sky/engine/core/dom/Element.h
sky/engine/core/dom/Element.cpp
sky/engine/core/dom/Node.h
sky/engine/core/dom/Range.cpp
sky/tests/dom/appendChild.sky
sky/tests/dom/appendChild-expected.txt
sky/tests/dom/document-child-mutations.sky
sky/tests/dom/document-child-mutations-expected.txt
sky/tests/dom/replaceChild.sky
sky/tests/dom/replaceChild-expected.txt
sky/tests/resources/dom-utils.sky
View unified diff
|
Download patch
« sky/engine/core/dom/ContainerNode.cpp
('K') |
« sky/tests/dom/appendChild.sky
('k') |
sky/tests/dom/document-child-mutations.sky »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
Running 5 tests
2
ok 1 appendChild should throw with invalid arguments
3
ok 2 appendChild should insert children
4
ok 3 appendChild should insert children with a fragment
5
ok 4 appendChild should throw when inserting a tree scope
6
ok 5 appendChild should throw when appending to a text
7
5 tests
8
5 pass
9
0 fail
OLD
NEW
« sky/engine/core/dom/ContainerNode.cpp
('K') |
« sky/tests/dom/appendChild.sky
('k') |
sky/tests/dom/document-child-mutations.sky »
('j') |
no next file with comments »
Issue 732203004: Clean up child checks in ContainerNode. (Closed)
Created 6 years, 1 month ago by esprehn
Modified 6 years, 1 month ago
Reviewers: ojan
Base URL: git@github.com:domokit/mojo.git@master
Comments: 5
This is Rietveld
408576698
Chromium Code Reviews
Issue 732203004:
Clean up child checks in ContainerNode. (Closed)
Base URL: git@github.com:domokit/mojo.git@master