Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 732203002: [Extensions Toolbar] Properly render newly-added extensions (Closed)

Created:
6 years, 1 month ago by Devlin
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Properly render newly-added extensions Fix a regression where newly-added extensions were not properly drawn. Also have the newly-installed extension button stop tracking, so it doesn't try to set state when the popup closes. BUG=433817 Committed: https://crrev.com/ebcd353dbbfff82230807a5d81dd8cd1b9b8441e Cr-Commit-Position: refs/heads/master@{#304503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Devlin
6 years, 1 month ago (2014-11-17 20:04:39 UTC) #2
Devlin
Looks like Avi's OOO - rsesek@, mind taking this one?
6 years, 1 month ago (2014-11-17 20:06:33 UTC) #4
Robert Sesek
How does this fix the NULL deref in the attached BUG=?
6 years, 1 month ago (2014-11-17 21:51:47 UTC) #5
Devlin
On 2014/11/17 21:51:47, Robert Sesek wrote: > How does this fix the NULL deref in ...
6 years, 1 month ago (2014-11-17 21:54:26 UTC) #6
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-17 21:55:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732203002/1
6 years, 1 month ago (2014-11-17 21:59:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 22:51:13 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ebcd353dbbfff82230807a5d81dd8cd1b9b8441e Cr-Commit-Position: refs/heads/master@{#304503}
6 years, 1 month ago (2014-11-17 22:52:45 UTC) #11
Michael Achenbach
6 years, 1 month ago (2014-11-18 08:29:42 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/736643002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Makes
ExtensionActionContextMenuControllerTest.BrowserAction flaky on Mac and Mac dbg:

Starting here:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/681
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29....

Powered by Google App Engine
This is Rietveld 408576698