Issue 732173003: Log message when XFA load fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 732173003: Log message when XFA load fails (Closed)

Created:
6 years ago by Tom Sepez

Modified:
6 years ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Visibility:
Public.

Log message when XFA load fails A minor change to make it obvious when generated/test XFA files are not being fully processed. R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/5645138a00db8b494e48eb214b95d15e620e1771

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	samples/pdfium_test.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Bo Xu

On 2014/12/05 18:49:29, Tom Sepez wrote: > Bo, a quick review. Thanks. lgtm

6 years ago (2014-12-05 18:55:16 UTC) #3

Tom Sepez

6 years ago (2014-12-05 21:30:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5645138a00db8b494e48eb214b95d15e620e1771 (presubmit successful).