sky/engine/core/html/HTMLImageElement.h - Issue 732163004: Teach HTMLImageElement that it doesn't need ::attach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/HTMLImageElement.h

Issue 732163004: Teach HTMLImageElement that it doesn't need ::attach. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Swap logic. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/HTMLImageElement.h

diff --git a/sky/engine/core/html/HTMLImageElement.h b/sky/engine/core/html/HTMLImageElement.h

index fc0497487b80f11365ef8512d2fbbc932ec6545b..4d7144a56e49b6f4b4575be84ee2be97ca224cde 100644

--- a/sky/engine/core/html/HTMLImageElement.h

+++ b/sky/engine/core/html/HTMLImageElement.h

@@ -93,7 +93,6 @@ private:

void selectSourceURL(ImageLoader::UpdateFromElementBehavior);

- virtual void attach(const AttachContext& = AttachContext()) override;

virtual RenderObject* createRenderer(RenderStyle*) override;

virtual bool canStartSelection() const override;