Teach HTMLImageElement that it doesn't need ::attach.

Teach HTMLImageElement that it doesn't need ::attach.

Instead of using a custom ::attach to do post insertion work
when assigning the image resource to the RenderImage, we should
just fix the logic inside RenderImage to be able to handle
not being in the tree yet when the resource is first set.

Soon attach will not be virtual anymore.

I also made RenderImage final and most methods private as there
are no longer subclasses.

R=ojan@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b79234bcbe463d667af7b5def1d0a14753941f66

[ojan, 2014-11-18 00:34:00]

ojan@chromium.org changed reviewers:
+ ojan@chromium.org

[ojan, 2014-11-18 00:34:00]

lgtm

https://codereview.chromium.org/732163004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderImage.cpp (right):

https://codereview.chromium.org/732163004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderImage.cpp:113: if
(m_imageResource->cachedImage() &&
m_imageResource->cachedImage()->hasDevicePixelRatioHeaderValue())
We con't care about this because we've removed the ability to do dpr on images?

[esprehn, 2014-11-18 03:06:04]

https://codereview.chromium.org/732163004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderImage.cpp (right):

https://codereview.chromium.org/732163004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderImage.cpp:113: if
(m_imageResource->cachedImage() &&
m_imageResource->cachedImage()->hasDevicePixelRatioHeaderValue())
On 2014/11/18 at 00:34:00, ojan wrote:
> We con't care about this because we've removed the ability to do dpr on
images?

No. I think we do need the http header dpr stuff? I swaped the lines for now,
want to look again?

[ojan, 2014-11-18 03:34:48]

lgtm

https://codereview.chromium.org/732163004/diff/40001/sky/engine/core/renderin...
File sky/engine/core/rendering/RenderImage.cpp (right):

https://codereview.chromium.org/732163004/diff/40001/sky/engine/core/renderin...
sky/engine/core/rendering/RenderImage.cpp:114:
RenderReplaced::imageChanged(newImage, rect);
This makes me a little future-proof nervous. If someone changes
RenderReplaced::imageChanged to do real work then it might not happen when we
first create the renderer. Not sure what the fix is. Seems a bit fragile though.

[esprehn, 2014-11-18 19:07:19]

On 2014/11/18 at 03:34:48, ojan wrote:
> lgtm
> 
>
https://codereview.chromium.org/732163004/diff/40001/sky/engine/core/renderin...
> File sky/engine/core/rendering/RenderImage.cpp (right):
> 
>
https://codereview.chromium.org/732163004/diff/40001/sky/engine/core/renderin...
> sky/engine/core/rendering/RenderImage.cpp:114:
RenderReplaced::imageChanged(newImage, rect);
> This makes me a little future-proof nervous. If someone changes
RenderReplaced::imageChanged to do real work then it might not happen when we
first create the renderer. Not sure what the fix is. Seems a bit fragile though.

I think we're going to delete all this someday, this is baby steps...

[esprehn, 2014-11-18 19:08:50]

Committed patchset #3 (id:40001) manually as
b79234bcbe463d667af7b5def1d0a14753941f66 (presubmit successful).