Issue 7320: Rename various text zoom related stuff to be more generic, since we now can...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7320: Rename various text zoom related stuff to be more generic, since we now can... (Closed)

Created:
12 years, 2 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rename various text zoom related stuff to be more generic, since we now can optionally zoom the page. I added an easy way in render_view to toggle between text zoom and full page zoom, and allowed the embedder to specify this in the glue layer. This allows me to fix the text zoom layout test, which specifically asks that the text be zoomed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3377

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -95 lines)			Patch
M	chrome/browser/browser_commands.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/render_view_host.h	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/render_view_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/common.vcproj	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/common/page_zoom.h	View		1 chunk	+15 lines, -10 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/common/text_zoom.h	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/renderer/render_view.h	View		4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View		3 chunks	+11 lines, -10 lines	0 comments	Download
M	webkit/glue/webview.h	View		1 chunk	+12 lines, -4 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View		3 chunks	+12 lines, -12 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View		2 chunks	+16 lines, -12 lines	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Yay full-page zoom!

Expand Messages | Collapse Messages