Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: src/core/SkBitmap.cpp

Issue 731973005: Add MultiPictureDraw to nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Remove assert that isn't always true when multithreaded Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/core/SkColorTable.h ('k') | src/core/SkColorTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkBitmap.cpp
diff --git a/src/core/SkBitmap.cpp b/src/core/SkBitmap.cpp
index f0ad029bea9285b74f03bbb0700ad09d1255c797..836825db24afcb0cc417aa175fd792d9b43a2271 100644
--- a/src/core/SkBitmap.cpp
+++ b/src/core/SkBitmap.cpp
@@ -1323,7 +1323,6 @@ void SkBitmap::validate() const {
if (fPixels) {
SkASSERT(fPixelRef);
robertphillips 2014/11/21 13:18:35 In a multithreaded world this bitmap's unlockPixel
mtklein 2014/11/21 13:40:44 Not lgtm This seems important for correctness. I
- SkASSERT(fPixelLockCount > 0);
SkASSERT(fPixelRef->isLocked());
SkASSERT(fPixelRef->rowBytes() == fRowBytes);
SkASSERT(fPixelRefOrigin.fX >= 0);
« no previous file with comments | « include/core/SkColorTable.h ('k') | src/core/SkColorTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698