Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: Source/core/paint/ClipRecorder.h

Issue 731933004: Get rid of LayerPainter::paintTransformedLayerIntoFragments(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add FIXME for fragmentOffset parameter to ClipRecorder(). Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/paint/LayerPainter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/ClipRecorder.h
diff --git a/Source/core/paint/ClipRecorder.h b/Source/core/paint/ClipRecorder.h
index a1dbc1dc193311b8157259f32d350ffcafc43678..4a5657f5b58b7a90b5a46a7f7cd5de4047fc9dc6 100644
--- a/Source/core/paint/ClipRecorder.h
+++ b/Source/core/paint/ClipRecorder.h
@@ -52,6 +52,10 @@ public:
// certain column.
// FIXME: The BorderRadiusClippingRule parameter is really useless now. If we want to skip self,
// why not just supply the parent layer as the first parameter instead?
+ // FIXME: The ClipRect passed is in visual coordinates (not flow thread coordinates), but at the
+ // same time we pass a fragmentOffset, so that we can translate from flow thread coordinates to
+ // visual coordinates. This may look rather confusing/redundant, but it is needed for rounded
+ // border clipping. Would be nice to clean up this.
explicit ClipRecorder(const RenderLayerModelObject*, GraphicsContext*, DisplayItem::Type, const ClipRect&, const LayerPaintingInfo* localPaintingInfo, const LayoutPoint& fragmentOffset, PaintLayerFlags, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
~ClipRecorder();
« no previous file with comments | « no previous file | Source/core/paint/LayerPainter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698