Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 73193007: Reorder fields/methods in JniInterface (Closed)

Created:
7 years, 1 month ago by Lambros
Modified:
7 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Reorder fields/methods in JniInterface Preparation for future cleanup CLs. No code changes here. Variables at the top, methods at the bottom. Cursor-related fields/methods grouped together. Native counterparts of methods moved next to their counterparts. Methods called on Display thread moved to the bottom. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235712

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -71 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 8 chunks +68 lines, -71 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Lambros
https://codereview.chromium.org/73193007/diff/30001/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java (left): https://codereview.chromium.org/73193007/diff/30001/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java#oldcode144 remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:144: */ I removed this comment, which accounts for the ...
7 years, 1 month ago (2013-11-15 19:36:27 UTC) #1
Sergey Ulanov
LGTM. IIRC java style guide is rather vague on how class members should be ordered, ...
7 years, 1 month ago (2013-11-15 20:38:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/73193007/30001
7 years, 1 month ago (2013-11-15 22:32:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/73193007/30001
7 years, 1 month ago (2013-11-16 01:22:33 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:48:45 UTC) #5
Message was sent while issue was closed.
Change committed as 235712

Powered by Google App Engine
This is Rietveld 408576698