Issue 73193004: Provide Type::Of and Type::CurrentOf operators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 73193004: Provide Type::Of and Type::CurrentOf operators (Closed)

Created:
7 years, 1 month ago by rossberg

Modified:
7 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Provide Type::Of and Type::CurrentOf operators R=verwaest@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=17796

Patch Set 2 : Comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -129 lines)			Patch
	M	src/types.h	View		6 chunks	+29 lines, -20 lines	0 comments	Download
	M	src/types.cc	View	1	6 chunks	+127 lines, -109 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm https://codereview.chromium.org/73193004/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/73193004/diff/1/src/types.cc#newcode144 src/types.cc:144: if (value->IsTrue() || value->IsFalse()) return kBoolean; nit: IsBoolean() ...

7 years, 1 month ago (2013-11-15 14:32:28 UTC) #2

rossberg

https://codereview.chromium.org/73193004/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/73193004/diff/1/src/types.cc#newcode144 src/types.cc:144: if (value->IsTrue() || value->IsFalse()) return kBoolean; On 2013/11/15 14:32:28, ...

7 years, 1 month ago (2013-11-15 15:13:05 UTC) #3

rossberg

7 years, 1 month ago (2013-11-15 15:14:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17796 (presubmit successful).

Expand Messages | Collapse Messages

Issue 73193004: Provide Type::Of and Type::CurrentOf operators (Closed)

Description

Patch Set 1 #

Patch Set 2 : Comment #

Messages