gn format: Make defines, deps, and sources lists always multline

gn format: Make defines, deps, and sources lists always multline

Results of formatting all of src are here: https://codereview.chromium.org/704363002/
ps#3 is before this patch, ps#4 is with this patch.

Usage is pretty inconsistent, we frequently have all of 

1.
deps = [ "x" ]

2.
deps = [
  "x"
]

3.
deps = [
  "x",
]

I categorize 2 as "wrong".

I could use "keep input style" to decide which of 1 & 3 to output (2 would change to 3), but on the other hand, I can't really discern any reason in most cases for why either 1 or 3 was chosen, so it seems like the sort of thing a formatter should really take an opinion on.

Anyone have strong ones?


R=brettw@chromium.org, brettw@chromium.org
BUG=348474

[scottmg, 2014-11-18 19:48:47]

scottmg@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2014-11-18 20:51:09]

I think "deps = ..." should always be multiline, but that it should be okay for
"deps += [ "foo" ]" to be single line. Is that the case here?

[scottmg, 2014-11-18 20:53:01]

On 2014/11/18 20:51:09, brettw wrote:
> I think "deps = ..." should always be multiline, but that it should be okay
for
> "deps += [ "foo" ]" to be single line. Is that the case here?

Ah, no, I did deps/sources/defines on the LHS with op being any of =, +=, or -=.
I can make it = assignment only and see how that looks.

What do you think about the LHSs? Are those three the right ones? Or only deps?
Or others that should be added?

[brettw, 2014-11-18 20:58:00]

I'd say remove defines (those are like flags and are rarely used anyway). And
then add deps- and sources-like things.
  - deps
  - public_deps
  - data_deps

  - sources
  - public
  - data
  - inputs

[brettw, 2014-11-18 20:58:05]

https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc
File tools/gn/command_format.cc (right):

https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc#n...
tools/gn/command_format.cc:138: bool prefer_multiline = false);
Google style says you are a bad person for doing this.

[Dirk Pranke, 2014-11-18 23:19:10]

Personally, I'd probably make all of the single-value lists be a single line,
but I don't feel super-strongly about it.

I would feel slightly more strongly about making += and -= of single-valued
things be a single line, since that seems far more common.

[scottmg, 2014-11-19 21:56:25]

On 2014/11/18 20:58:00, brettw wrote:
> I'd say remove defines (those are like flags and are rarely used anyway). And
> then add deps- and sources-like things.
>   - deps
>   - public_deps
>   - data_deps
> 
>   - sources
>   - public
>   - data
>   - inputs

Did this, and made it only apply to = (not -=/+=). Semi-relatedly "datadeps"
(not "data_deps") might be spelled wrong.

[scottmg, 2014-11-19 21:56:33]

https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc
File tools/gn/command_format.cc (right):

https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc#n...
tools/gn/command_format.cc:138: bool prefer_multiline = false);
On 2014/11/18 20:58:05, brettw wrote:
> Google style says you are a bad person for doing this.

Done.

[scottmg, 2014-11-24 22:40:47]

On 2014/11/19 21:56:33, scottmg wrote:
> https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc
> File tools/gn/command_format.cc (right):
> 
>
https://codereview.chromium.org/731923003/diff/1/tools/gn/command_format.cc#n...
> tools/gn/command_format.cc:138: bool prefer_multiline = false);
> On 2014/11/18 20:58:05, brettw wrote:
> > Google style says you are a bad person for doing this.
> 
> Done.

I reworked this while doing https://codereview.chromium.org/748863003/ so this
is rolled into there now (closing this one).

[tfarina, 2014-11-25 01:49:32]

Option 3 please.

deps = [
  "x",
]

It might be a bit verbose, but when some comes later to add a new entry to the
list it will be a single line change, rather than a 3 line one. (For me it is a
productivity boost, but that might be just me).

+1 for always multiline!