Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 731893002: Add a simple scheduler for animation frames (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
jamesr, ernstm
CC:
mojo-reviews_chromium.org, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add a simple scheduler for animation frames This CL adds a simple scheduler for animation frames that holds a given interval in a given phase. The scheduler can be told the estimated duration of the BeginFrame callback and can adjust the callback to hit a given vsync interval. This CL also makes ganesh_app use this scheduler to animate. R=jamesr@chromium.org, ernstm@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d6f119dea629ee005e03f32a5e025e7d940e25c7

Patch Set 1 #

Patch Set 2 : Use in ganesh_app #

Patch Set 3 : scoped_refptr #

Patch Set 4 : Fix math #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -17 lines) Patch
M examples/ganesh_app/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M examples/ganesh_app/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M examples/ganesh_app/ganesh_view.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M examples/ganesh_app/ganesh_view.cc View 1 3 chunks +28 lines, -5 lines 0 comments Download
A + mc/scheduler/BUILD.gn View 1 1 chunk +10 lines, -9 lines 0 comments Download
A + mc/scheduler/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
A mc/scheduler/scheduler.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A mc/scheduler/scheduler.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A mc/scheduler/time_interval.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A mc/scheduler/time_interval.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A mc/scheduler/timer.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A mc/scheduler/timer.cc View 1 2 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
This CL is based on the cc/scheduler, but without all the abstraction and complexity. In ...
6 years, 1 month ago (2014-11-16 06:00:27 UTC) #2
jamesr
lgtm but put this somewhere under sky/
6 years, 1 month ago (2014-11-17 18:40:13 UTC) #3
abarth-chromium
Committed patchset #4 (id:60001) manually as d6f119dea629ee005e03f32a5e025e7d940e25c7 (presubmit successful).
6 years, 1 month ago (2014-11-17 19:24:12 UTC) #4
abarth-chromium
6 years, 1 month ago (2014-11-17 19:24:57 UTC) #5
Message was sent while issue was closed.
Moved to sky/scheduler

Also, dropped the changes to ganesh_app

Powered by Google App Engine
This is Rietveld 408576698