Stop building ui_unittests target.

Stop building ui_unittests target.

Bots and everything else should be now using ui_base_unittests.

BUG=331829, 373148, 299841, 103304
TEST=None
R=sky@chromium.org,thestig@chromium.org,maruel@chromium.org

Committed: https://crrev.com/af63c7b7c086cfe8c994c7ebee8370a3c106c201
Cr-Commit-Position: refs/heads/master@{#304615}

[tfarina, 2014-11-16 00:14:26]

tfarina@chromium.org changed reviewers:
+ maruel@chromium.org

[tfarina, 2014-11-16 00:15:15]

sky -> everything
thestig -> tools/valgrind
maruel -> PRESUBMIT.py

Thanks!

[tfarina, 2014-11-16 00:18:48]

tfarina@chromium.org changed reviewers:
+ jochen@chromium.org
- maruel@chromium.org

[tfarina, 2014-11-16 00:18:49]

Changing Marc-Antoine for the review of PRESUBMIT.py (things are changing fast
:().

jochen -> PRESUBMIT.py

[sky, 2014-11-17 15:59:50]

LGTM

[Lei Zhang, 2014-11-17 20:38:52]

tools/valgrind/chrome_tests.py lgtm

[jochen (gone - plz use gerrit), 2014-11-18 13:24:46]

why don't you also deleted the ui_unittests target in this CL?

[tfarina, 2014-11-18 14:57:42]

On Tue, Nov 18, 2014 at 11:24 AM, <jochen@chromium.org> wrote:

> why don't you also deleted the ui_unittests target in this CL?
>
> Because it will make it more complicated. And I prefer to do one step at a
time. If something goes wrong, then it will be more work to me to fix it
(revert, reland, etc). Since I don't have much time to hack on Chromium
these days I prefer to stand on the safe side, I think doing this way is
safer.

I also think it is easier for the reviewer to review the CL that way.



> https://codereview.chromium.org/731883002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-11-18 14:58:36]

hum, whatever is easier for you

lgtm

[tfarina, 2014-11-18 15:13:17]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-11-18 15:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731883002/1

[commit-bot: I haz the power, 2014-11-18 16:18:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-18 16:19:02]

Patchset 1 (id:??) landed as
https://crrev.com/af63c7b7c086cfe8c994c7ebee8370a3c106c201
Cr-Commit-Position: refs/heads/master@{#304615}

[Nico, 2014-11-19 22:36:28]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2014-11-19 22:36:29]

All the clang/win FYI bots are now red, failing to run ui_unittests:
http://build.chromium.org/p/chromium.fyi/console?category=win%20clang

E.g.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang(shared)%20tester

I guess there are some references to ui_unittests left somewhere after all? Or
what do we need to do to fix this?