chrome/browser/android/provider/chrome_browser_provider.h - Issue 731873003: ChromeBrowserProvider shouldn't own the FaviconService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.h

Issue 731873003: ChromeBrowserProvider shouldn't own the FaviconService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/provider/chrome_browser_provider.h

diff --git a/chrome/browser/android/provider/chrome_browser_provider.h b/chrome/browser/android/provider/chrome_browser_provider.h

index bb430e091c9be27ac246b1a30eee281a7a02a3e4..d36ed99f3dc82ee9054c0781de8641dff6a65cc2 100644

--- a/chrome/browser/android/provider/chrome_browser_provider.h

+++ b/chrome/browser/android/provider/chrome_browser_provider.h

@@ -191,7 +191,6 @@ class ChromeBrowserProvider : public BaseBookmarkModelObserver,

history::TopSites* top_sites_;

scoped_ptr<AndroidHistoryProviderService> service_;

- scoped_ptr<FaviconService> favicon_service_;

base::CancelableTaskTracker cancelable_task_tracker_;

« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »