Issue 731873003: ChromeBrowserProvider shouldn't own the FaviconService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 731873003: ChromeBrowserProvider shouldn't own the FaviconService (Closed)

Created:
6 years, 1 month ago by michaelbai

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

More Reviews

Description

ChromeBrowserProvider shouldn't own the FaviconService As FaviconService is KeyedService and will be deleted along with profile. BUG=411435 TBR=Tedchoc Review URL: https://codereview.chromium.org/739713002 Cr-Commit-Position: refs/heads/master@{#304690} Committed: https://chromium.googlesource.com/chromium/src/+/8c5b8c707daa9c026540a63f6f1e1c5981f5909c

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -11 lines)			Patch
	M	chrome/browser/android/provider/chrome_browser_provider.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/android/provider/chrome_browser_provider.cc	View		4 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

michaelbai

Committed patchset #1 (id:1) manually as 8c5b8c707daa9c026540a63f6f1e1c5981f5909c (presubmit successful).

6 years, 1 month ago (2014-11-19 19:29:30 UTC) #1

kerz_google

6 years, 1 month ago (2014-11-20 04:55:52 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/740853002/ by kerz@google.com.

The reason for reverting is: Broke the branch build.
https://uberchromegw.corp.google.com/i/chrome.mobile/builders/arm%20stable/bu....

Expand Messages | Collapse Messages