Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: sky/engine/platform/graphics/CompositingReasons.h

Issue 731863003: Remove CSSCompositing (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: preland Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/platform/RuntimeEnabledFeatures.in ('k') | sky/engine/platform/graphics/CompositingReasons.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/platform/graphics/CompositingReasons.h
diff --git a/sky/engine/platform/graphics/CompositingReasons.h b/sky/engine/platform/graphics/CompositingReasons.h
index 96325da7b89350b246b3da0227c5ca212341dcee..b43d27d9e85365b3ec4fac2f89bcc44bcb849c82 100644
--- a/sky/engine/platform/graphics/CompositingReasons.h
+++ b/sky/engine/platform/graphics/CompositingReasons.h
@@ -47,11 +47,11 @@ const uint64_t CompositingReasonTransformWithCompositedDescendants = UINT6
const uint64_t CompositingReasonOpacityWithCompositedDescendants = UINT64_C(1) << 29;
const uint64_t CompositingReasonMaskWithCompositedDescendants = UINT64_C(1) << 30;
const uint64_t CompositingReasonFilterWithCompositedDescendants = UINT64_C(1) << 32;
-const uint64_t CompositingReasonBlendingWithCompositedDescendants = UINT64_C(1) << 33;
+// TODO(sky): Unused 33
const uint64_t CompositingReasonClipsCompositingDescendants = UINT64_C(1) << 34;
const uint64_t CompositingReasonPerspectiveWith3DDescendants = UINT64_C(1) << 35;
const uint64_t CompositingReasonPreserve3DWith3DDescendants = UINT64_C(1) << 36;
-const uint64_t CompositingReasonIsolateCompositedDescendants = UINT64_C(1) << 38;
+// TODO(sky): Unused 37 & 38
// The root layer is a special case that may be forced to be a layer, but also it needs to be
// a layer if anything else in the subtree is composited.
@@ -100,11 +100,9 @@ const uint64_t CompositingReasonComboAllDirectStyleDeterminedReasons =
const uint64_t CompositingReasonComboCompositedDescendants =
CompositingReasonTransformWithCompositedDescendants
- | CompositingReasonIsolateCompositedDescendants
| CompositingReasonOpacityWithCompositedDescendants
| CompositingReasonMaskWithCompositedDescendants
| CompositingReasonFilterWithCompositedDescendants
- | CompositingReasonBlendingWithCompositedDescendants
| CompositingReasonClipsCompositingDescendants;
const uint64_t CompositingReasonCombo3DDescendants =
@@ -134,8 +132,6 @@ const uint64_t CompositingReasonComboReasonsThatRequireOwnBacking =
| CompositingReasonOpacityWithCompositedDescendants
| CompositingReasonMaskWithCompositedDescendants
| CompositingReasonFilterWithCompositedDescendants
- | CompositingReasonBlendingWithCompositedDescendants
- | CompositingReasonIsolateCompositedDescendants
| CompositingReasonPreserve3DWith3DDescendants; // preserve-3d has to create backing store to ensure that 3d-transformed elements intersect.
const uint64_t CompositingReasonComboSquashableReasons =
« no previous file with comments | « sky/engine/platform/RuntimeEnabledFeatures.in ('k') | sky/engine/platform/graphics/CompositingReasons.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698