Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 731863003: Remove CSSCompositing (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: preland Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
index 760ae652af38b3ff0d5a37daa1827e7630727375..91e5d301268fcd94ad88fea34738c51c41269e2e 100644
--- a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -179,11 +179,6 @@ void CompositedLayerMapping::createPrimaryGraphicsLayer()
updateOpacity(renderer()->style());
updateTransform(renderer()->style());
updateFilters(renderer()->style());
-
- if (RuntimeEnabledFeatures::cssCompositingEnabled()) {
- updateLayerBlendMode(renderer()->style());
- updateIsRootForIsolatedGroup();
- }
}
void CompositedLayerMapping::destroyGraphicsLayers()
@@ -224,21 +219,6 @@ void CompositedLayerMapping::updateFilters(const RenderStyle* style)
m_graphicsLayer->setFilters(owningLayer().computeFilterOperations(style));
}
-void CompositedLayerMapping::updateLayerBlendMode(const RenderStyle* style)
-{
- setBlendMode(style->blendMode());
-}
-
-void CompositedLayerMapping::updateIsRootForIsolatedGroup()
-{
- bool isolate = m_owningLayer.shouldIsolateCompositedDescendants();
-
- // non stacking context layers should never isolate
- ASSERT(m_owningLayer.stackingNode()->isStackingContext() || !isolate);
-
- m_graphicsLayer->setIsRootForIsolatedGroup(isolate);
-}
-
void CompositedLayerMapping::updateContentsOpaque()
{
// For non-root layers, background is always painted by the primary graphics layer.
@@ -579,11 +559,6 @@ void CompositedLayerMapping::updateGraphicsLayerGeometry(const RenderLayer* comp
if (m_owningLayer.scrollableArea() && m_owningLayer.scrollableArea()->scrollsOverflow())
m_owningLayer.scrollableArea()->positionOverflowControls(IntSize());
- if (RuntimeEnabledFeatures::cssCompositingEnabled()) {
- updateLayerBlendMode(renderer()->style());
- updateIsRootForIsolatedGroup();
- }
-
updateContentsRect();
updateBackgroundColor();
updateDrawsContent();

Powered by Google App Engine
This is Rietveld 408576698