sky/engine/core/css/CSSComputedStyleDeclaration.cpp - Issue 731863003: Remove CSSCompositing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

Issue 731863003: Remove CSSCompositing (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: preland Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | sky/engine/core/css/CSSPrimitiveValueMappings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

index cdbc960a60836e048275345dd72284363ac0d816..ec1160cb0414186c6a748dc018e142c193eb63e9 100644

--- a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

+++ b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

@@ -76,7 +76,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyAnimationPlayState,

CSSPropertyAnimationTimingFunction,

CSSPropertyBackgroundAttachment,

- CSSPropertyBackgroundBlendMode,

CSSPropertyBackgroundClip,

CSSPropertyBackgroundColor,

CSSPropertyBackgroundImage,

@@ -126,7 +125,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyFontWeight,

CSSPropertyHeight,

CSSPropertyImageRendering,

- CSSPropertyIsolation,

CSSPropertyLeft,

CSSPropertyLetterSpacing,

CSSPropertyLineHeight,

@@ -141,7 +139,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyMaxWidth,

CSSPropertyMinHeight,

CSSPropertyMinWidth,

- CSSPropertyMixBlendMode,

CSSPropertyObjectFit,

CSSPropertyObjectPosition,

CSSPropertyOpacity,

@@ -1571,8 +1568,6 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert

return cssValuePool().createValue(style->hyphenationString(), CSSPrimitiveValue::CSS_STRING);

case CSSPropertyImageRendering:

return CSSPrimitiveValue::create(style->imageRendering());

- case CSSPropertyIsolation:

- return cssValuePool().createValue(style->isolation());

case CSSPropertyLeft:

return valueForPositionOffset(*style, CSSPropertyLeft, renderer);

case CSSPropertyLetterSpacing:

@@ -2171,15 +2166,7 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert

return cssValuePool().createIdentifierValue(CSSValueNone);

case CSSPropertyWebkitFilter:

return valueForFilter(renderer, *style);

- case CSSPropertyMixBlendMode:

- return cssValuePool().createValue(style->blendMode());

- case CSSPropertyBackgroundBlendMode: {

- RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();

- for (const FillLayer* currLayer = &style->backgroundLayers(); currLayer; currLayer = currLayer->next())

- list->append(cssValuePool().createValue(currLayer->blendMode()));

- return list.release();

- }

case CSSPropertyBackground:

return valuesForBackgroundShorthand();

case CSSPropertyBorder: {