Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 731833002: Using sequence<KeyUsage> in WebCrypto IDL files rather than KeyUsage[] (Closed)

Created:
6 years, 1 month ago by Paritosh Kumar
Modified:
6 years, 1 month ago
Reviewers:
eroman
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Using sequence<KeyUsage> in WebCrypto IDL files rather than KeyUsage[] As per specs https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#dfn-SubtleCrypto we should use sequence<KeyUsage> instead of KeyUsage[] and DOMString[]. BUG=433526 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Paritosh Kumar
Please have a look, and please suggest if there is need of any test or ...
6 years, 1 month ago (2014-11-15 11:49:25 UTC) #2
eroman
Hi Paritosh, the change itself looksgood. However I cannot approve until you have signed the ...
6 years, 1 month ago (2014-11-18 02:49:28 UTC) #3
Paritosh Kumar
Thanks Eric But I have signed the CLA from Samsung, and added myself in AUTHORS ...
6 years, 1 month ago (2014-11-18 02:59:19 UTC) #4
eroman
My mistake then, LGTM
6 years, 1 month ago (2014-11-18 03:03:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731833002/1
6 years, 1 month ago (2014-11-18 05:04:15 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 06:48:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185501

Powered by Google App Engine
This is Rietveld 408576698