BrowserCdmManager: remove CDMs on correct thread on RenderFrameDeleted.

BrowserCdmManager: remove CDMs on correct thread on RenderFrameDeleted.

R=xhwang@chromium.org,damienv@chromium.org
BUG=388930
Committed: https://crrev.com/46498cd67fd86c0e859c356c154ae28aaf76bfa2
Cr-Commit-Position: refs/heads/master@{#304431}

[xhwang, 2014-11-15 08:51:46]

lgtm

[damienv1, 2014-11-16 00:00:47]

Just a few nits (some cosmetic changes I would do).

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.cc (right):

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:124: void
BrowserCdmManager::RenderFrameDeleted(int render_frame_id) {
nit: early return feels more natural here.

if (!task_runner_->RunsTaskOnCurrentTHread()) {
  PostTask(...);
  return;
}
RemoveAllCdmForFrame(...);

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.h (right):

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.h:112: void RemoveCdmsForFrame(int
render_frame_id);
nit: Would rather name it: RemoveAllCdmForFrame (Cdms looks a bit weird
especially since we don't use "CDMs").

[gunsch, 2014-11-17 16:17:38]

Verified (manually) EME playback still works.

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.cc (right):

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.cc:124: void
BrowserCdmManager::RenderFrameDeleted(int render_frame_id) {
On 2014/11/16 00:00:46, damienv1 wrote:
> nit: early return feels more natural here.
> 
> if (!task_runner_->RunsTaskOnCurrentTHread()) {
>   PostTask(...);
>   return;
> }
> RemoveAllCdmForFrame(...);

Done.

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
File content/browser/media/cdm/browser_cdm_manager.h (right):

https://codereview.chromium.org/731793002/diff/1/content/browser/media/cdm/br...
content/browser/media/cdm/browser_cdm_manager.h:112: void RemoveCdmsForFrame(int
render_frame_id);
On 2014/11/16 00:00:46, damienv1 wrote:
> nit: Would rather name it: RemoveAllCdmForFrame (Cdms looks a bit weird
> especially since we don't use "CDMs").

Done.

[gunsch, 2014-11-17 16:17:43]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-11-17 16:18:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/731793002/20001

[commit-bot: I haz the power, 2014-11-17 17:09:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-17 17:09:58]

Patchset 2 (id:??) landed as
https://crrev.com/46498cd67fd86c0e859c356c154ae28aaf76bfa2
Cr-Commit-Position: refs/heads/master@{#304431}