Fixing operator so that bCheckRight isn't always true. Unknown effect!

Fixing operator so that bCheckRight isn't always true. Unknown effect!

VC++'s /analyze points out that this expression:
    FX_BOOL bCheckRight = type != 'D' || type != 'W';"
is always true. This means that the tests for the right edge of a word

Original patch from Bruce Dawson(brucedawson@chromium.org)

BUG=427616
R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/0d8b679fb2dbb3f4df9437f2a2b618e1eab1aa1b

[brucedawson, 2014-11-15 00:31:09]

brucedawson@chromium.org changed reviewers:
+ bo_xu@foxitsoftware.com, jun_fang@foxitsoftware.com

[brucedawson, 2014-11-15 00:32:28]

This is another bug found by /analyze. I'm not sure if this is the correct fix
or not, or what the implications are. Any thoughts?

Currently bCheckRight will always be true, which is presumably not the intent.
If we want to suppress the warning without changing behavior then we could
change the code to just be:

FX_BOOL bCheckRight = TRUE;

[jun_fang, 2014-11-18 19:57:31]

On 2014/11/15 00:32:28, brucedawson wrote:
> This is another bug found by /analyze. I'm not sure if this is the correct fix
> or not, or what the implications are. Any thoughts?
> 
> Currently bCheckRight will always be true, which is presumably not the intent.
> If we want to suppress the warning without changing behavior then we could
> change the code to just be:
> 
> FX_BOOL bCheckRight = TRUE;

LGTM. I think that it's a typo. Thanks for your finding and fixing it.

[brucedawson, 2014-11-18 21:50:32]

Committed patchset #1 (id:1) manually as
0d8b679fb2dbb3f4df9437f2a2b618e1eab1aa1b (presubmit successful).