Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 731673002: Implement EVP_PKEY_supports_digest in Windows EVP_PKEY wrappers. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@client-auth
Project:
chromium
Visibility:
Public.

Description

Implement EVP_PKEY_supports_digest in Windows EVP_PKEY wrappers. This allows BoringSSL's SSL implementation to account for the CNG or CAPI provider's capabilities when choosing a hash to sign. Per the fixes in https://crbug.com/278370, we assume CAPI keys and CNG RSA keys of size 1024-bit or below can only support SHA-1. This also prevents BoringSSL from choosing SHA-224 which we can't sign with CNG either. BUG=418822 Committed: https://crrev.com/2a5e750faa7a7bd8ee6635f208e509e792cdd70a Cr-Commit-Position: refs/heads/master@{#305920}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : clang format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M net/ssl/openssl_platform_key_win.cc View 1 2 4 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
This depends on the other client auth CL and the tower of changes ending at, ...
6 years, 1 month ago (2014-11-14 22:47:47 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-11-22 01:08:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731673002/40001
6 years ago (2014-11-26 22:42:05 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-11-27 00:03:15 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-27 00:04:07 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a5e750faa7a7bd8ee6635f208e509e792cdd70a
Cr-Commit-Position: refs/heads/master@{#305920}

Powered by Google App Engine
This is Rietveld 408576698