Issue 7316011: Release all keys on blur.

Issue 7316011: Release all keys on blur. (Closed)

Created:
9 years, 5 months ago by Jamie

Modified:
9 years, 5 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Release all keys on blur. BUG=84285 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91914

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ReleaseAllKeys to InputHandler instead of PepperInputHandler. #

Patch Set 3 : Take a copy of pressed_keys_ before iterating. #

Patch Set 4 : Out-of-lined InputHandler dtor. #

Patch Set 5 : Fixed to work after ajwong's refactoring. #

Patch Set 6 : Fixed copyright dates. #

Patch Set 7 : Avoid error messages on blur before the session is created. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -4 lines)			Patch
M	remoting/client/input_handler.h	View	1 2 3 4 5	3 chunks	+8 lines, -2 lines	0 comments	Download
M	remoting/client/input_handler.cc	View	1 2 3 4 5	3 chunks	+19 lines, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_instance.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	remoting/client/plugin/chromoting_scriptable_object.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	remoting/webapp/me2mom/remoting.js	View	1 2 3 4 5 6	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

In order to guard against missed keyups while the plugin doesn't have focus, release all ...

9 years, 5 months ago (2011-07-06 22:45:10 UTC) #1

garykac

LGTM http://codereview.chromium.org/7316011/diff/1/remoting/client/plugin/chromoting_instance.cc File remoting/client/plugin/chromoting_instance.cc (right): http://codereview.chromium.org/7316011/diff/1/remoting/client/plugin/chromoting_instance.cc#newcode303 remoting/client/plugin/chromoting_instance.cc:303: = static_cast<PepperInputHandler*>(input_handler_.get()); Why not add ReleaseAllKeys() to input_handler ...

9 years, 5 months ago (2011-07-07 00:19:11 UTC) #2

Jamie

9 years, 5 months ago (2011-07-08 18:38:06 UTC) #3

http://codereview.chromium.org/7316011/diff/1/remoting/client/plugin/chromoti...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/7316011/diff/1/remoting/client/plugin/chromoti...
remoting/client/plugin/chromoting_instance.cc:303: =
static_cast<PepperInputHandler*>(input_handler_.get());
On 2011/07/07 00:19:11, garykac wrote:
> Why not add ReleaseAllKeys() to input_handler and avoid the cast?

Fair point. Done.

Expand Messages | Collapse Messages