Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 73153003: Remove dead code from IDB (chromium side) (Closed)

Created:
7 years, 1 month ago by alecflett
Modified:
7 years, 1 month ago
Reviewers:
dgrogan, jam, jsbell
CC:
chromium-reviews, jsbell, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

Remove dead code from IDB (chromium side) BUG= TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235708

Patch Set 1 #

Total comments: 6

Patch Set 2 : clang format to fix long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -63 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 2 chunks +3 lines, -9 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 5 chunks +1 line, -10 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 3 chunks +1 line, -13 lines 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/indexed_db_context.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
alecflett
I found this neat tool for detecting dead code. Here is the stuff it found ...
7 years, 1 month ago (2013-11-14 23:05:50 UTC) #1
jsbell
lgtm https://codereview.chromium.org/73153003/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (left): https://codereview.chromium.org/73153003/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc#oldcode775 content/browser/indexed_db/indexed_db_backing_store.cc:775: bool IndexedDBBackingStore::UpdateIDBDatabaseMetaData( Makes sense - we never update ...
7 years, 1 month ago (2013-11-14 23:34:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/1
7 years, 1 month ago (2013-11-15 02:39:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/1
7 years, 1 month ago (2013-11-15 04:28:55 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36497
7 years, 1 month ago (2013-11-15 05:33:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/1
7 years, 1 month ago (2013-11-15 17:25:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36563
7 years, 1 month ago (2013-11-15 17:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/1
7 years, 1 month ago (2013-11-15 18:25:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36584
7 years, 1 month ago (2013-11-15 19:11:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/270001
7 years, 1 month ago (2013-11-15 19:27:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/270001
7 years, 1 month ago (2013-11-15 22:30:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/73153003/270001
7 years, 1 month ago (2013-11-16 01:21:06 UTC) #12
alecflett
jam@ - quick review for code removal?
7 years, 1 month ago (2013-11-16 03:17:10 UTC) #13
jam
On 2013/11/16 03:17:10, alecflett wrote: > jam@ - quick review for code removal? lgtm (didn't ...
7 years, 1 month ago (2013-11-18 05:53:06 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:38:26 UTC) #15
Message was sent while issue was closed. 
Change committed as 235708

Powered by Google App Engine
This is Rietveld 408576698