Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 731473007: Update gtest and gmock to the latest versions (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Update gtest and gmock to the latest versions. In b6a0183ccec7, gtest and gmock were held back at older versions with limited C++11 support, because the then-current heads of each did not work well in environments with C++11 language support but pre-C++11 library support. This is the environment that Chrome code for Mac builds in. All necessary patches for this have been merged upstream, and this has been corrected in the current released versions of gtest and gmock. TEST=* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/d0212ebaee39b8d1557482b6fc9c16366726cd94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-18 23:19:47 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-19 16:34:08 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-19 16:37:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0212ebaee39b8d1557482b6fc9c16366726cd94 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698