Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 731473002: Improved git cl patch generated commit message to include patchset information (Closed)

Created:
6 years, 1 month ago by carlosk
Modified:
6 years, 1 month ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Improved git cl patch generated commit message to include patchset information and a link to it. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292940

Patch Set 1 #

Total comments: 2

Patch Set 2 : Just a nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M git_cl.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
carlosk
brettw@: PTAL? Just a minor patch that I found useful while using git cl patch ...
6 years, 1 month ago (2014-11-14 09:43:40 UTC) #2
Dirk Pranke
lgtm w/ nit. https://codereview.chromium.org/731473002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/731473002/diff/1/git_cl.py#newcode2375 git_cl.py:2375: % {'i': issue, 'p': patchset}]) Nit: ...
6 years, 1 month ago (2014-11-14 18:00:36 UTC) #4
carlosk
Thanks. IDK if trybots are a thing for this project as I tried git cl ...
6 years, 1 month ago (2014-11-14 18:10:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731473002/20001
6 years, 1 month ago (2014-11-14 18:10:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 292940
6 years, 1 month ago (2014-11-14 18:12:52 UTC) #8
Dirk Pranke
6 years, 1 month ago (2014-11-14 18:30:08 UTC) #9
Message was sent while issue was closed.
On 2014/11/14 18:10:24, carlosk wrote:
> Thanks.
> 
> IDK if trybots are a thing for this project as I tried git cl try and got an
> error message. I hope just pressing commit should be enough...

Nope, there are no trybots, just the CQ, and that should be good enough.

Powered by Google App Engine
This is Rietveld 408576698