Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 731453002: Adding two codelabs for cds2014. (Closed)

Created:
6 years, 1 month ago by bradn
Modified:
6 years, 1 month ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding two codelabs for cds2014. Adding two codelabs: * PNaCl web devenv used to deploy a pnacl python app. * devenv chrome app used to learn ppapi graphics 2d. BUG=None TEST=local + manual R=binji@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3ec1799a199d75eda8bfe2040252df4e05e10735

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1407 lines, -178 lines) Patch
M native_client_sdk/doc_generated/_static/pygments.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
A native_client_sdk/doc_generated/cds2014/cpp.html View 1 1 chunk +272 lines, -0 lines 0 comments Download
A native_client_sdk/doc_generated/cds2014/index.html View 1 1 chunk +100 lines, -0 lines 0 comments Download
A native_client_sdk/doc_generated/cds2014/python.html View 1 1 chunk +240 lines, -0 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/distributing.html View 1 1 chunk +7 lines, -13 lines 0 comments Download
M native_client_sdk/doc_generated/io2014.html View 1 4 chunks +12 lines, -65 lines 0 comments Download
A native_client_sdk/doc_generated/nacldev.html View 1 1 chunk +56 lines, -0 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 1 chunk +29 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/cds2014/cpp.rst View 1 1 chunk +162 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/cds2014/cpp_summary.inc View 1 1 chunk +46 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/cds2014/index.rst View 1 chunk +30 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/cds2014/python.rst View 1 chunk +117 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/cds2014/python_summary.inc View 1 1 chunk +43 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/io2014.rst View 3 chunks +4 lines, -98 lines 0 comments Download
A native_client_sdk/src/doc/nacldev.rst View 1 1 chunk +45 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/cleanup_app.inc View 1 chunk +12 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/cleanup_web.inc View 1 chunk +10 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/clipboard_app.inc View 1 1 chunk +36 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/clipboard_web.inc View 1 1 chunk +40 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/editing.inc View 1 chunk +22 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/git.inc View 1 chunk +13 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/navigating.inc View 1 1 chunk +16 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/setup_app.inc View 1 1 chunk +33 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/setup_web.inc View 1 1 chunk +37 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/nacldev/web_tools_note.inc View 1 chunk +19 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/sitemap.rst View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
6 years, 1 month ago (2014-11-14 08:48:23 UTC) #1
binji
This looks great, Brad! lgtm https://codereview.chromium.org/731453002/diff/1/native_client_sdk/src/doc/cds2014/cpp.rst File native_client_sdk/src/doc/cds2014/cpp.rst (right): https://codereview.chromium.org/731453002/diff/1/native_client_sdk/src/doc/cds2014/cpp.rst#newcode146 native_client_sdk/src/doc/cds2014/cpp.rst:146: <http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/cpp/>`_. point to docs ...
6 years, 1 month ago (2014-11-14 19:19:17 UTC) #2
bradn
https://codereview.chromium.org/731453002/diff/1/native_client_sdk/src/doc/cds2014/cpp.rst File native_client_sdk/src/doc/cds2014/cpp.rst (right): https://codereview.chromium.org/731453002/diff/1/native_client_sdk/src/doc/cds2014/cpp.rst#newcode146 native_client_sdk/src/doc/cds2014/cpp.rst:146: <http://src.chromium.org/viewvc/chrome/trunk/src/ppapi/cpp/>`_. On 2014/11/14 19:19:17, binji wrote: > point to ...
6 years, 1 month ago (2014-11-14 23:55:35 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3ec1799a199d75eda8bfe2040252df4e05e10735 Cr-Commit-Position: refs/heads/master@{#304304}
6 years, 1 month ago (2014-11-14 23:59:41 UTC) #4
bradn
6 years, 1 month ago (2014-11-14 23:59:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3ec1799a199d75eda8bfe2040252df4e05e10735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698