Issue 731433002: Service Worker: respondWith() invokes stopImmediatePropagation()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 731433002: Service Worker: respondWith() invokes stopImmediatePropagation() (Closed)

Created:
6 years, 1 month ago by falken

Modified:
6 years, 1 month ago

Reviewers:
horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Service Worker: respondWith() invokes stopImmediatePropagation() As per spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/51#issuecomment-51172079 BUG=432827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185357

Patch Set 1 #

Patch Set 2 : newline #

Patch Set 3 : fmt #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
A +	LayoutTests/http/tests/serviceworker/fetch-event-respond-with-stops-propagation.html	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
A	LayoutTests/http/tests/serviceworker/resources/fetch-event-respond-with-stops-propagation-worker.js	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/modules/serviceworkers/FetchEvent.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731433002/40001

6 years, 1 month ago (2014-11-14 07:34:29 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 08:48:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 185357

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages