Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: pnacl/driver/pnacl-translate.py

Issue 731423004: Add options for base dir and redirecting files to IRT open resource and use it. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: uncomment assert Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pnacl/driver/pnacl-translate.py
diff --git a/pnacl/driver/pnacl-translate.py b/pnacl/driver/pnacl-translate.py
index b03eb7cfe62e8abb9cb0cfc34e3c25a31dcd7fc0..c2232fdc808527a9bfd2d9bd47fb87ac05ea3db8 100755
--- a/pnacl/driver/pnacl-translate.py
+++ b/pnacl/driver/pnacl-translate.py
@@ -353,15 +353,13 @@ def main(argv):
# The x86->arm emulator is very flaky when threading is used, so don't
# do module splitting when using it.
env.set('SPLIT_MODULE', '1')
- else:
- modules = env.getone('SPLIT_MODULE')
- if modules != '1':
- env.append('LLC_FLAGS_EXTRA', '-split-module=' + modules)
- env.append('LD_FLAGS', '-split-module=' + modules)
- if not env.getbool('SANDBOXED') and env.getbool('STREAM_BITCODE'):
- # Do not set -streaming-bitcode for sandboxed mode, because it is already
- # in the default command line.
- env.append('LLC_FLAGS_EXTRA', '-streaming-bitcode')
+ modules = env.getone('SPLIT_MODULE')
+ env.append('LLC_FLAGS_EXTRA', '-split-module=' + modules)
+ env.append('LD_FLAGS', '-split-module=' + modules)
+ if not env.getbool('SANDBOXED') and env.getbool('STREAM_BITCODE'):
+ # Do not set -streaming-bitcode for sandboxed mode, because it is already
Mark Seaborn 2014/12/01 20:54:17 Nit: shouldn't this go before the "if"? It's a bi
jvoung (off chromium) 2014/12/01 22:00:09 Done.
+ # in the default command line.
+ env.append('LLC_FLAGS_EXTRA', '-streaming-bitcode')
# If there's a bitcode file, translate it now.
tng = driver_tools.TempNameGen(inputs + bcfiles, output)

Powered by Google App Engine
This is Rietveld 408576698