Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.h

Issue 731423002: Remove OriginChip code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view.h
diff --git a/chrome/browser/ui/omnibox/omnibox_view.h b/chrome/browser/ui/omnibox/omnibox_view.h
index af3efbc88d68b68d0a794df95e89e21940a23ae0..7ca541237fc9f39c26cf153e6660930c55d6b647 100644
--- a/chrome/browser/ui/omnibox/omnibox_view.h
+++ b/chrome/browser/ui/omnibox/omnibox_view.h
@@ -44,9 +44,6 @@ class OmniboxView {
CommandUpdater* command_updater() { return command_updater_; }
const CommandUpdater* command_updater() const { return command_updater_; }
- // Handle mouse release events concerning the origin chip.
- void HandleOriginChipMouseRelease();
-
// Shared cross-platform focus handling.
void OnDidKillFocus();
@@ -60,8 +57,7 @@ class OmniboxView {
// Called when any relevant state changes other than changing tabs.
virtual void Update() = 0;
- // Updates the placeholder text with the value of GetHintText() if the
- // origin chip is enabled.
+ // Updates the placeholder text with the value of GetHintText() if possible.
Justin Donnelly 2014/11/21 19:15:24 To avoid ambiguity, suggest replacing "if possible
groby-ooo-7-16 2014/12/02 18:40:10 Slightly different wording, omitting "field trial"
virtual void UpdatePlaceholderText() = 0;
// Asks the browser to load the specified match, using the supplied

Powered by Google App Engine
This is Rietveld 408576698