Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 731423002: Remove OriginChip code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix histogram.xml review feedback. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 334 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
335 switches::kDisableSearchButtonInOmnibox, ""}, 335 switches::kDisableSearchButtonInOmnibox, ""},
336 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR, 336 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR,
337 switches::kEnableSearchButtonInOmniboxForStr, ""}, 337 switches::kEnableSearchButtonInOmniboxForStr, ""},
338 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP, 338 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP,
339 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""}, 339 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
340 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED, 340 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
341 switches::kEnableSearchButtonInOmniboxAlways, ""} 341 switches::kEnableSearchButtonInOmniboxAlways, ""}
342 }; 342 };
343 343
344 // See comment above for kSearchButtonInOmniboxChoices. The same reasoning 344 const Experiment::Choice kTouchScrollingModeChoices[] = {
345 // applies here.
346 const Experiment::Choice kOriginChipChoices[] = {
347 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 345 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
348 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""}, 346 { IDS_FLAGS_TOUCH_SCROLLING_MODE_TOUCHCANCEL,
349 { IDS_FLAGS_ORIGIN_CHIP_ALWAYS, switches::kEnableOriginChipAlways, ""}, 347 switches::kTouchScrollingMode,
350 { IDS_FLAGS_ORIGIN_CHIP_ON_SRP, switches::kEnableOriginChipOnSrp, ""} 348 switches::kTouchScrollingModeTouchcancel },
349 { IDS_FLAGS_TOUCH_SCROLLING_MODE_ASYNC_TOUCHMOVE,
350 switches::kTouchScrollingMode,
351 switches::kTouchScrollingModeAsyncTouchmove },
352 { IDS_FLAGS_TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE,
353 switches::kTouchScrollingMode,
354 switches::kTouchScrollingModeSyncTouchmove },
351 }; 355 };
352 356
353 const Experiment::Choice kExtensionContentVerificationChoices[] = { 357 const Experiment::Choice kExtensionContentVerificationChoices[] = {
354 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 358 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
355 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_BOOTSTRAP, 359 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_BOOTSTRAP,
356 switches::kExtensionContentVerification, 360 switches::kExtensionContentVerification,
357 switches::kExtensionContentVerificationBootstrap }, 361 switches::kExtensionContentVerificationBootstrap },
358 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE, 362 { IDS_FLAGS_EXTENSION_CONTENT_VERIFICATION_ENFORCE,
359 switches::kExtensionContentVerification, 363 switches::kExtensionContentVerification,
360 switches::kExtensionContentVerificationEnforce }, 364 switches::kExtensionContentVerificationEnforce },
(...skipping 1325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1686 }, 1690 },
1687 #endif 1691 #endif
1688 { 1692 {
1689 "num-raster-threads", 1693 "num-raster-threads",
1690 IDS_FLAGS_NUM_RASTER_THREADS_NAME, 1694 IDS_FLAGS_NUM_RASTER_THREADS_NAME,
1691 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION, 1695 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION,
1692 kOsAll, 1696 kOsAll,
1693 MULTI_VALUE_TYPE(kNumRasterThreadsChoices) 1697 MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
1694 }, 1698 },
1695 { 1699 {
1696 "origin-chip-in-omnibox",
1697 IDS_FLAGS_ORIGIN_CHIP_NAME,
1698 IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
1699 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1700 MULTI_VALUE_TYPE(kOriginChipChoices)
1701 },
1702 {
1703 "search-button-in-omnibox", 1700 "search-button-in-omnibox",
1704 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME, 1701 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
1705 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION, 1702 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
1706 kOsCrOS | kOsMac | kOsWin | kOsLinux, 1703 kOsCrOS | kOsMac | kOsWin | kOsLinux,
1707 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices) 1704 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
1708 }, 1705 },
1709 { 1706 {
1710 "ignore-autocomplete-off-autofill", 1707 "ignore-autocomplete-off-autofill",
1711 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME, 1708 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME,
1712 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION, 1709 IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION,
(...skipping 1056 matching lines...) Expand 10 before | Expand all | Expand 10 after
2769 } 2766 }
2770 2767
2771 const Experiment* GetExperiments(size_t* count) { 2768 const Experiment* GetExperiments(size_t* count) {
2772 *count = num_experiments; 2769 *count = num_experiments;
2773 return experiments; 2770 return experiments;
2774 } 2771 }
2775 2772
2776 } // namespace testing 2773 } // namespace testing
2777 2774
2778 } // namespace about_flags 2775 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698