Source/core/frame/PinchViewport.h - Issue 731413002: Adjust DOMWindow properties to emulate old style pinch semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/PinchViewport.h

Issue 731413002: Adjust DOMWindow properties to emulate old style pinch semantics (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changes from feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/Window/window-scaled-viewport-properties.html ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/frame/PinchViewport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/PinchViewport.h

diff --git a/Source/core/frame/PinchViewport.h b/Source/core/frame/PinchViewport.h

index f26ebae0a0d80cf5c6138ffa4d53a3112abe656c..7ff94412f83aa5d029d35a4ca3a96efeea49a53b 100644

--- a/Source/core/frame/PinchViewport.h

+++ b/Source/core/frame/PinchViewport.h

@@ -114,6 +114,7 @@ public:

FloatRect visibleRect() const;

// The viewport rect relative to the document origin, in partial CSS pixels.

+ // FIXME: This should be a DoubleRect since scroll offsets are now doubles.

FloatRect visibleRectInDocument() const;

// Scroll the main frame and pinch viewport so that the given rect in the